API Rename FormField Value to getFormattedValue

silverstripe · Jan 31, 2025 · 9835716 · 9835716
1 parent 07d4a5d
commit 9835716
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Controllers/ElementalAreaController.php b/src/Controllers/ElementalAreaController.php
@@ -456,10 +456,10 @@ private function createValidationExceptionWithNamespaces(
             $messageCast = $message['messageCast'] ?? ValidationResult::CAST_TEXT;
             if ($messageFieldName) {
                 $fieldName = sprintf(EditFormFactory::FIELD_NAMESPACE_TEMPLATE, $element->ID, $messageFieldName);
-                $params = [$fieldName, $messageText, $messageType, null, $messageCast];
+                $params = [$fieldName, $messageText, $messageType, '', $messageCast];
                 $validationResultWithNameSpaces->addFieldError(...$params);
             } else {
-                $validationResultWithNameSpaces->addError($messageText, $messageType, null, $messageCast);
+                $validationResultWithNameSpaces->addError($messageText, $messageType, '', $messageCast);
             }
             $signatures[$signature] = $message;
         }

diff --git a/src/Forms/TextCheckboxGroupField.php b/src/Forms/TextCheckboxGroupField.php
@@ -93,7 +93,7 @@ public function performReadonlyTransformation()
             if ($titleField) {
                 $field->replaceField('Title', LiteralField::create(
                     'Title',
-                    $titleField->Value()
+                    $titleField->getFormattedValue()
                 ));
             }
 
@@ -103,7 +103,8 @@ public function performReadonlyTransformation()
             if ($showTitle) {
                 $field->replaceField('ShowTitle', LiteralField::create(
                     'ShowTitle',
-                    $showTitle->Value() === 'Yes' ? $displayedText : $notDisplayedText
+                    // Intentionally using getValue() instead of getFormattedValue() to get the raw value
+                    $showTitle->getValue() === 'Yes' ? $displayedText : $notDisplayedText
                 )->addExtraClass('show-title'));
             }
         }