Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLEditorField::setRows method doesn't work in Elemental #1132

Closed
sabina-talipova opened this issue Jan 17, 2024 · 1 comment
Closed

HTMLEditorField::setRows method doesn't work in Elemental #1132

sabina-talipova opened this issue Jan 17, 2024 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Jan 17, 2024

Description

HTMLEditorField::setRows method doesn't work in Elemental since height attribute is not passed.

Related issue

Replication steps

Add the following to your content block and then try to inline edit it

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('Content');
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent1')->setRows(2));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent2')->setRows(4));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent3')->setRows(5));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent4')->setRows(10));
  
        return $fields;
    }

PRs

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants