Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX HTMLEditorField::setRows with Elemental #1660

Merged
merged 1 commit into from
Jan 25, 2024
Merged

FIX HTMLEditorField::setRows with Elemental #1660

merged 1 commit into from
Jan 25, 2024

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Jan 24, 2024
Closed
@sabina-talipova sabina-talipova force-pushed the pulls/2.1/fix-elemental-htmleditor branch from e5f1d4f to b1f948f Compare January 24, 2024 03:00
@sabina-talipova sabina-talipova force-pushed the pulls/2.1/fix-elemental-htmleditor branch from b1f948f to 799add9 Compare January 24, 2024 22:53
GuySartorelli
GuySartorelli approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected.

@GuySartorelli GuySartorelli merged commit 20dbe25 into silverstripe:2.1 Jan 25, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.1/fix-elemental-htmleditor branch January 25, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli