API Set extension hook implementation visibility to protected #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/6/protect-hooks
branch
2 times, most recently
from
cf2f021 to
ab145f9
Compare
emteknetnz
commented
May 20, 2024
src/Models/BaseElement.php
Outdated
| * | ||
| * {@inheritDoc} | ||
| */ | ||
| public function updateSort() |
There was a problem hiding this comment.
This method is added so that Resolver.php can call it, previously it was calling onBeforeWrite() direclty
emteknetnz
force-pushed
the
pulls/6/protect-hooks
branch
from
ab145f9 to
d5842f9
Compare
emteknetnz
force-pushed
the
pulls/6/protect-hooks
branch
from
d5842f9 to
8e3649f
Compare
emteknetnz
commented
May 21, 2024
| */ | ||
| public function onBeforeWrite() | ||
| public function ensureSortSet() |
There was a problem hiding this comment.
This method has been added so that Resolver.php can call it directly, previously it was calling onBeforeWrite() directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10514