Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add $startIndex param to Pos method #1222

Closed
wants to merge 1 commit into from
Closed

ENH Add $startIndex param to Pos method #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Models/BaseElement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,11 +1261,12 @@ public function TotalItems()
/**
* Returns the position of the current element.
*
* @param int $startIndex Number to start count from.
* @return int
*/
public function Pos()
public function Pos($startIndex = 1)
Comment on lines -1266 to +1267
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the initiative, but unfortunately we can't add new parameters (even optional ones) to public API outside of a major release as per the major release policy and definition of public API.

We could accept this in CMS 6, so feel free to submit a new pull request targetting the 6 branch - but I'll close this one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. It's disappointing that the policy is to class optional parameters as a breaking change. However if that's the policy then fair enough I'll add another PR.

{
return ($this->Parent()->Elements()->filter('Sort:LessThan', $this->Sort)->count() + 1);
return ($this->Parent()->Elements()->filter('Sort:LessThan', $this->Sort)->count() + $startIndex);
}

/**
Expand Down