Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Require framework ^5.3 #1304

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 9, 2025

Issue silverstripe/.github#357

Fixes https://github.com/silverstripe/silverstripe-graphql/actions/runs/12640442927/job/35285220759 which broke because was using framwork 5.2 instead of 5.3 because this line was different - 5.2 - 5.3

This PR is a little unusual because there's nothing in elemental 5.3 that strictly requires API in framework 5.3, it's just that requiring a later version of framework is the only way I can think of fixing this. It may make more a little clearer to keep the ^5.2 framework contraint and add a conflict for framework < 5.3 instead, let me know if you would prefer that and I'll update the PR.

Broken tests were:

    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/add-block-element-to-data-object.feature:11
    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/edit-block-element.feature:80
    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/inline-block-validation.feature:57
    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/non-page-save-validation.feature:18
    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/page-save-validation.feature:19
    vendor/dnadesign/silverstripe-elemental/tests/Behat/features/versioned-status-block-element.feature:17

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make more a little clearer to keep the ^5.2 framework contraint and add a conflict for framework < 5.3 instead

That sounds nonsensical to me - just bumping the dep is much clearer.

@GuySartorelli GuySartorelli merged commit 741486c into silverstripe:5.3 Jan 9, 2025
26 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.3/conflict branch January 9, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants