Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Don't publicly expose extension hook methods #10515

Conversation

GuySartorelli
Copy link
Member

Extension hook methods should be protected - this should be best practices for CMS 5 now that it is a possibility as it reduces the public API surface extensions introduce.

Parent Issue

@GuySartorelli GuySartorelli force-pushed the pulls/5/protected-extension-hooks branch from 54e7a78 to 4454d8f Compare September 26, 2022 21:55
@GuySartorelli GuySartorelli force-pushed the pulls/5/protected-extension-hooks branch from 4454d8f to 55fda28 Compare September 27, 2022 00:57
@GuySartorelli GuySartorelli marked this pull request as ready for review September 27, 2022 01:12
@GuySartorelli GuySartorelli changed the base branch from 5 to 6 May 13, 2024 21:09
@emteknetnz
Copy link
Member

This is something that definitely requires a level of automated code scanning, it's simply too error prone to do this manually

Will create the PRs using https://github.com/emteknetnz/extension-protector/

@emteknetnz emteknetnz closed this May 16, 2024
@GuySartorelli GuySartorelli deleted the pulls/5/protected-extension-hooks branch May 16, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants