NEW Add abstraction for sql RIGHT JOIN #10954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Sep 21, 2023
| /** | ||
| * Add a JOIN criteria | ||
| */ | ||
| private function addJoin($table, $type, $onPredicate, $tableAlias = null, $order = 20, $parameters = []): static |
There was a problem hiding this comment.
This method wasn't strictly necessary, but it seems appropriate to reduce code duplication by moving the repeated code into this new method.
I can see a use case for this being public, but that's not the purpose of this PR. We can always do that as a separate future enhancement down the road.
GuySartorelli
force-pushed
the
pulls/5/right-join
branch
from
29a980c to
f2a0204
Compare
GuySartorelli
commented
Sep 21, 2023
| public function testInnerJoin() | ||
| public function testJoinSQL() |
There was a problem hiding this comment.
This wasn't actually testing inner join - it was just testing the SQL output for both inner and left join. So I've just renamed it to match what it's actually testing, and added right join to it since it already had both existing join types in there.
GuySartorelli
force-pushed
the
pulls/5/right-join
branch
from
f2a0204 to
47881da
Compare
emteknetnz
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently adding a RIGHT JOIN to a query, especially to a
DataQuery, is quite difficult.Right joins are really powerful in conjunction with Common Table Expressions (aka WITH clauses), so now is a good time to add this abstraction.
Issue