ENH Enable allowing collisions for field statements #10957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's a bit abstract as its own PR, but it makes sense in conjunction with the unit tests being added to #10943 - specifically the "recursive CTE with extrapolated data" test scenario in
DataQueryTest
. That test (and indeed that entire query scenario) is not possible without allowing this, or something like this. Note that test uses an old name for the method - I'll update that once this and all other related PRs are merged.It would probably be better to instead have a "coallesce" method, but the problem with that is we don't have a clean way to define the order of coalescence because a lot of fields aren't added until the query is finalised, so that method would be highly un-intuitive unless we made some breaking changes.
Issue