FIX Add extraEmptyValues to TreedropdownField #11044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5.1/treedropdown-required
branch
from
3518887 to
0c6600b
Compare
emteknetnz
force-pushed
the
pulls/5.1/treedropdown-required
branch
from
0c6600b to
3ec745f
Compare
sabina-talipova
suggested changes
Nov 12, 2023
| /** | ||
| * @return array | ||
| */ | ||
| public function getSchemaValidation() |
There was a problem hiding this comment.
Could you, please, add unit test for this method.
There was a problem hiding this comment.
Done
Note - the parent card on this is a SPIKE so don't merge this just yet, need to agree with team first that we're happy with the approach before we merge anything
emteknetnz
force-pushed
the
pulls/5.1/treedropdown-required
branch
from
3ec745f to
95e3827
Compare
GuySartorelli
requested changes
Nov 13, 2023
|
Closed in favor of #11068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1616
Test setup provided here silverstripe/silverstripe-admin#1616 (comment)