Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use class name instead of self #11270

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/5.2/remove-self branch 3 times, most recently from 49115d0 to 66667c5 Compare June 14, 2024 10:15
src/Control/Controller.php Outdated Show resolved Hide resolved
src/Core/Extensible.php Outdated Show resolved Hide resolved
src/ORM/Filters/SearchFilter.php Outdated Show resolved Hide resolved
thirdparty/php-peg/Compiler.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.2/remove-self branch from 66667c5 to 34e2de8 Compare June 17, 2024 01:48
@emteknetnz emteknetnz force-pushed the pulls/5.2/remove-self branch from 34e2de8 to 620c1b0 Compare June 17, 2024 21:37
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 2787393 into silverstripe:5.2 Jun 18, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/remove-self branch June 18, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants