Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Replace Extension subclasses #11348

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 20, 2024

Issue #11050

@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch 7 times, most recently from 457013a to 386170d Compare August 25, 2024 22:16
@emteknetnz emteknetnz marked this pull request as ready for review August 25, 2024 22:52
@emteknetnz emteknetnz force-pushed the pulls/6/replace-extension-subclasses branch from 386170d to 8ffda9e Compare August 28, 2024 05:00
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when the behat PR is resolved in case merging this breaks behat in the meantime.

@GuySartorelli GuySartorelli merged commit 3d79660 into silverstripe:6 Aug 29, 2024
4 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/replace-extension-subclasses branch August 29, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants