Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Remove support for MySQL 5 #11354

Merged
merged 1 commit into from
Aug 28, 2024
Merged

DEP Remove support for MySQL 5 #11354

merged 1 commit into from
Aug 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 28, 2024 •
edited
Loading

Issue #11292

Linting failure is unrelated

@emteknetnz emteknetnz mentioned this pull request Aug 28, 2024
Closed
GuySartorelli
GuySartorelli approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sword we had tests specifically for MySQL 5, but I can't find any trace of them so I guess not.

LGTM.

@GuySartorelli GuySartorelli merged commit e969786 into silverstripe:6 Aug 28, 2024
12 of 13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/mysql5 branch August 28, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli