Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Made the GridFieldDeleteAction method getRemoveAction() protected #11369

Merged

Conversation

mooror
Copy link
Contributor

@mooror mooror commented Sep 11, 2024

Description

I expected to be able to subclass the GridFieldDeleteAction and alter the underlying GridField_FormAction without having to completely overwrite parent code

I found that the getRemoveAction() method is private and has no extension points making it impossible to change the GridField_FormAction while keeping existing parent code

I have changed the access modifier for getRemoveAction() from private to protected to fix this issue

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice an simple. Thanks.

@GuySartorelli GuySartorelli merged commit 52e4574 into silverstripe:5 Sep 11, 2024
15 checks passed
@mooror
Copy link
Contributor Author

mooror commented Sep 11, 2024

Epic! Thanks Guy 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants