API Made the GridFieldDeleteAction method getRemoveAction() protected #11369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I expected to be able to subclass the
GridFieldDeleteAction
and alter the underlyingGridField_FormAction
without having to completely overwrite parent codeI found that the
getRemoveAction()
method is private and has no extension points making it impossible to change theGridField_FormAction
while keeping existing parent codeI have changed the access modifier for
getRemoveAction()
fromprivate
toprotected
to fix this issueManual testing steps
Issues
Pull request checklist