ENH Allow overriding GridFieldFilterHeader placeholder #11418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Oct 6, 2024
Comment on lines
-333
to
-344
| private function getTitle(GridField $gridField, object $inst): string | ||
| { | ||
| if ($gridField->Title) { | ||
| return $gridField->Title; | ||
| } | ||
|
|
||
| if (ClassInfo::hasMethod($inst, 'i18n_plural_name')) { | ||
| return $inst->i18n_plural_name(); | ||
| } | ||
|
|
||
| return ClassInfo::shortName($inst); | ||
| } |
There was a problem hiding this comment.
Moved this method because private methods should be nearer the bottom than public methods.
GuySartorelli
commented
Oct 6, 2024
Comment on lines
+486
to
+493
| private function getTitle(object $inst): string | ||
| { | ||
| if (ClassInfo::hasMethod($inst, 'i18n_plural_name')) { | ||
| return $inst->i18n_plural_name(); | ||
| } | ||
|
|
||
| return ClassInfo::shortName($inst); | ||
| } |
There was a problem hiding this comment.
Note I've removed the code that relied on $gridField->Title because that was effectively dead code.
I've removed the corresponding parameter for $gridField from the method signature since this is a private method.
See #11416 (comment) for why I did that instead of changing it to use the Title() method.
2 tasks
|
Good stuff in here. I like 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to override the placeholder text for a
GridFieldFilterHeader.Issue
GridFieldFilterHeader::getTitle()doesn't use the title set onGridField#11416