ENH Do not rely on flush variable #11440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
emteknetnz
commented
Oct 22, 2024
| $kernel = Injector::inst()->get(Kernel::class); | ||
| if (!$flush || (method_exists($kernel, 'isFlushed') && $kernel->isFlushed())) { | ||
| return false; | ||
| if ($request->getURL() === 'dev/build') { |
There was a problem hiding this comment.
I've redone the logic on this one since it was already checked Injector::inst()->get(Kernel::class)->isFlushed() and returning false if isFlushed() was true.
emteknetnz
force-pushed
the
pulls/6/no-get-flush
branch
from
7e22fc4 to
b1b469a
Compare
GuySartorelli
approved these changes
Oct 22, 2024
GuySartorelli
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#324
Notes on a couple of places where
$request->getVar('flush')is used that were not changed:RequestFlushDiscover::lookupRequest() - not changed because it's the central place that checks
$request->getVar('flush'), somewhere has to do it after allSapphireTest::start() - unlike the new sake, it still uses
CLIRequestBuilder::createFromEnvironment()which returns anHTTPRequest. Without significant refactoring it needs to stay this way as you need to be able to use without sake e.g.vendor/bin/phpunit path/to/something