API Remove API which is now in silverstripe/silverstripe-template-engine #11451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
GuySartorelli
commented
Nov 4, 2024
Comment on lines
-31
to
-34
| <!-- use short array syntax (less thirdparty) --> | ||
| <rule ref="Generic.Arrays.DisallowLongArraySyntax"> | ||
| <exclude-pattern>/thirdparty/*</exclude-pattern> | ||
| </rule> |
There was a problem hiding this comment.
That directory is now completely removed from framework
Comment on lines
-29
to
-30
| * - THIRDPARTY_DIR: Path relative to webroot, e.g. "framework/thirdparty" | ||
| * - THIRDPARTY_PATH: Absolute filepath, e.g. "/var/www/my-webroot/framework/thirdparty" |
There was a problem hiding this comment.
That directory doesn't exist in framework anymore, so I'm removing the related constants.
I can't imagine anyone was using them given the only thing in there was the code which takes the template parser .peg and builds out the template parser .php
This was referenced Nov 5, 2024
emteknetnz
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm choosing to leave the config here because it's framework that cares about having a default template engine, it's not the template engine module that explicitly wants itself to be the default.
The failing CI in this PR will go green once silverstripe/silverstripe-assets#634 is merged
Issue