API Deprecate renamed validators #11490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
ff8253f to
ad2d3fc
Compare
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
ad2d3fc to
b37542b
Compare
GuySartorelli
requested changes
Dec 4, 2024
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
b37542b to
ee49690
Compare
GuySartorelli
requested changes
Dec 5, 2024
src/Forms/FieldsValidator.php
Outdated
Comment on lines
10
to
18
| * @deprecated 5.4.0 Will be replaced with functionality inside Silverstripe\Forms\Form::validate() | ||
| */ | ||
| class FieldsValidator extends Validator | ||
| { | ||
| public function __construct() | ||
| { | ||
| Deprecation::noticeWithNoReplacment( | ||
| '5.4.0', | ||
| 'Will be replaced with functionality inside Silverstripe\Forms\Form::validate()', |
There was a problem hiding this comment.
Suggested change
| * @deprecated 5.4.0 Will be replaced with functionality inside Silverstripe\Forms\Form::validate() | |
| */ | |
| class FieldsValidator extends Validator | |
| { | |
| public function __construct() | |
| { | |
| Deprecation::noticeWithNoReplacment( | |
| '5.4.0', | |
| 'Will be replaced with functionality inside Silverstripe\Forms\Form::validate()', | |
| * @deprecated 5.4.0 Will be replaced with functionality inside SilverStripe\Forms\Form::validate() | |
| */ | |
| class FieldsValidator extends Validator | |
| { | |
| public function __construct() | |
| { | |
| Deprecation::noticeWithNoReplacment( | |
| '5.4.0', | |
| 'Will be replaced with functionality inside SilverStripe\Forms\Form::validate()', |
emteknetnz
force-pushed
the
pulls/5/depr-valid
branch
from
ee49690 to
7d25f7f
Compare
GuySartorelli
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10908