Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use updated league/csv api #11508

Merged
merged 1 commit into from
Dec 12, 2024
Merged

ENH Use updated league/csv api #11508

merged 1 commit into from
Dec 12, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 12, 2024 •
edited
Loading

Issue silverstripe/.github#349

#11507 being merged and merged up to fix the broken unit tests, this just fixes deprecation warnings

Fixes https://github.com/silverstripe/silverstripe-framework/actions/runs/12270153106/job/34283940618#step:12:125

Deprecation notices only happen on php 8.4

PHP Deprecated:  Method League\Csv\Writer::setNewline() is deprecated since league/csv:9.8.0, use League\Csv\Writer::setEndOfLine() in /home/runner/work/silverstripe-framework/silverstripe-framework/src/Forms/GridField/GridFieldExportButton.php on line 183
PHP Deprecated:  Constant League\Csv\ByteSequence::BOM_UTF8 is deprecated since league/csv:9.16.0, use League\Csv\Bom:Utf8 instead in /home/runner/work/silverstripe-framework/silverstripe-framework/src/Forms/GridField/GridFieldExportButton.php on line 184
PHP Deprecated:  Method League\Csv\AbstractCsv::getContent() is deprecated since league/csv:9.7.0, use League\Csv\AbstractCsv::toString() instead in /home/runner/work/silverstripe-framework/silverstripe-framework/src/Forms/GridField/GridFieldExportButton.php on line 273
PHP Deprecated:  Constant League\Csv\ByteSequence::BOM_UTF8 is deprecated since league/csv:9.16.0, use League\Csv\Bom:Utf8 instead in /home/runner/work/silverstripe-framework/silverstripe-framework/tests/php/Forms/GridField/GridFieldExportButtonTest.php on line 227
PHP Deprecated:  Method League\Csv\AbstractCsv::__toString() is deprecated since league/csv:9.1.0, use League\Csv\AbstractCsv::toString() instead in /home/runner/work/silverstripe-framework/silverstripe-framework/tests/php/Forms/GridField/GridFieldExportButtonTest.php on line 67

@emteknetnz emteknetnz mentioned this pull request Dec 12, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/6.0/fix-unit-test branch from de12af1 to 0c3bc42 Compare December 12, 2024 01:50
@emteknetnz emteknetnz changed the title MNT Fix Unit test ENH Use updated league/csv api Dec 12, 2024
@emteknetnz emteknetnz force-pushed the pulls/6.0/fix-unit-test branch from 0c3bc42 to d624e1b Compare December 12, 2024 02:04
@emteknetnz emteknetnz marked this pull request as ready for review December 12, 2024 02:38
GuySartorelli
GuySartorelli approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit d3be004 into silverstripe:6.0 Dec 12, 2024
10 of 13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/fix-unit-test branch December 12, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli