Skip to content

Commit

Permalink
Merge pull request #220 from creative-commoners/pulls/2/validation-in…
Browse files Browse the repository at this point in the history
…terface

API Update validate signature
  • Loading branch information
GuySartorelli authored Dec 17, 2024
2 parents 250d5dd + 0bdefa9 commit 5989e77
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion code/BasicFieldsTestPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
use SilverStripe\Forms\CompositeField;
use SilverStripe\Forms\Validation\RequiredFieldsValidator;
use SilverStripe\Forms\HTMLReadonlyField;
use SilverStripe\Core\Validation\ValidationResult;

class BasicFieldsTestPage extends TestPage
{
Expand Down Expand Up @@ -402,7 +403,7 @@ public function getCMSValidator()
return new RequiredFieldsValidator('Required');
}

public function validate()
public function validate(): ValidationResult
{
$result = parent::validate();
if (!$this->Validated || $this->Validated < 1 || $this->Validated > 3) {
Expand Down
3 changes: 2 additions & 1 deletion code/multitab-validation/MultiTabPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use SilverStripe\Forms\EmailField;
use SilverStripe\Forms\Validation\RequiredFieldsValidator;
use SilverStripe\Forms\TextField;
use SilverStripe\Core\Validation\ValidationResult;

if (!class_exists(Page::class)) {
return;
Expand Down Expand Up @@ -59,7 +60,7 @@ public function getCMSValidator()
]);
}

public function validate()
public function validate(): ValidationResult
{
$result = parent::validate();

Expand Down

0 comments on commit 5989e77

Please sign in to comment.