Skip to content

Commit

Permalink
Require silverstripe/registry
Browse files Browse the repository at this point in the history
Those class_exists() check don't work with class manifests.
Check the logic in ClassManifestVisitor - it just parses PHP until it finds
class definitions. Which means you'll have those files in the manifest,
but when dev/build tries to instantiate them it fails
with an InjectorNotFoundException.

We could argue that this should be fixed in core,
but I'm not sure that this style of conditional classes
needs to be supported.
  • Loading branch information
chillu committed Aug 13, 2020
1 parent dc3f096 commit 82a660d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"silverstripe/cms": "~4.0",
"guzzlehttp/guzzle": "~6.0",
"fzaninotto/faker": "^1.7",
"silverstripe/vendor-plugin": "^1.0"
"silverstripe/vendor-plugin": "^1.0",
"silverstripe/registry": "~2"
},
"extra": {
"expose": [
Expand Down

0 comments on commit 82a660d

Please sign in to comment.