ENH Take advantage of auto-scaffolded formfields for link #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
GuySartorelli
force-pushed
the
pulls/2/scaffolded-fields
branch
from
8bcc9a4 to
e8dc065
Compare
GuySartorelli
commented
Jun 24, 2024
| $fields->removeByName(['Content', 'HasOneLinkID', 'HasManyLinksID']); | ||
| $fields->removeByName(['Content']); |
There was a problem hiding this comment.
Formfields aren't autoscaffolded for SiteTree which this extension is made for.
GuySartorelli
force-pushed
the
pulls/2/scaffolded-fields
branch
from
e8dc065 to
6f42552
Compare
GuySartorelli
force-pushed
the
pulls/2/scaffolded-fields
branch
from
6f42552 to
865de81
Compare
emteknetnz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on the changes made to linkfield in silverstripe/silverstripe-linkfield#301
Issue