Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Add ElementalAreasPageExtension #193

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/1/elemental-multi branch from 251e940 to 32b15a8 Compare July 11, 2024 01:35
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PRs are approved

@emteknetnz emteknetnz force-pushed the pulls/1/elemental-multi branch from 32b15a8 to 8bbb950 Compare July 22, 2024 21:41
@emteknetnz
Copy link
Member Author

Have made a change after it was approved

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have just reused existing modeladmin and object, and applied the extension in behat... but this will do.

@GuySartorelli GuySartorelli merged commit 9aada4a into silverstripe:1 Jul 24, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/1/elemental-multi branch July 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants