Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Rename method #209

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Rename method #209

merged 1 commit into from
Dec 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Nov 4, 2024
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as draft November 4, 2024 02:47
@emteknetnz emteknetnz force-pushed the pulls/2/form-field-valid branch 2 times, most recently from 719e108 to d481ac2 Compare November 12, 2024 00:25
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
@emteknetnz emteknetnz force-pushed the pulls/2/form-field-valid branch 2 times, most recently from 394b9f3 to 33d5ea1 Compare November 21, 2024 00:45
GuySartorelli
GuySartorelli approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready - though would be good if the commit message says which method is being renamed.

@emteknetnz emteknetnz force-pushed the pulls/2/form-field-valid branch from 33d5ea1 to dd062f3 Compare November 26, 2024 04:30
GuySartorelli
GuySartorelli approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 86d5528 into silverstripe:2 Dec 2, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/2/form-field-valid branch December 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli