Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Import correct InputOption class #65

Merged
merged 1 commit into from
Nov 26, 2024
Merged

FIX Import correct InputOption class #65

merged 1 commit into from
Nov 26, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 21, 2024 •
edited
Loading

@emteknetnz emteknetnz force-pushed the pulls/2/remove-support branch from 7b4ddbb to e1a4bf7 Compare November 21, 2024 00:40
@emteknetnz emteknetnz marked this pull request as draft November 21, 2024 00:42
@emteknetnz emteknetnz mentioned this pull request Nov 25, 2024
Closed
15 tasks
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
GuySartorelli
GuySartorelli approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not actually part of the card you've linked it to though.

@GuySartorelli
Copy link
Member

the failing tests look unrelated.

@GuySartorelli GuySartorelli merged commit bee12c6 into silverstripe:2 Nov 26, 2024
5 of 8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/remove-support branch November 26, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli