Merge pull request #174 from creative-commoners/pulls/4/empty-list

ENH Show a cannot create message when types is empty
silverstripe · Jan 18, 2024 · 4bc4883 · 4bc4883
2 parents 663a13f + 2927d50
commit 4bc4883
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/src/components/LinkPicker/LinkPicker.js b/client/src/components/LinkPicker/LinkPicker.js
@@ -40,12 +40,13 @@ const LinkPicker = ({ types, onModalSuccess, onModalClosed, canCreate }) => {
   const shouldOpenModal = typeKey !== '';
   const className = classnames('link-picker', 'form-control');
   const typeArray = Object.values(types);
+  const message = i18n._t('LinkField.CANNOT_CREATE_LINK', 'Cannot create link');
 
-  if (!canCreate) {
+  if (!canCreate || typeArray.length === 0) {
     return (
       <div className={className}>
         <div className="link-picker__cannot-create">
-          {i18n._t('LinkField.CANNOT_CREATE_LINK', 'Cannot create link')}
+          {message}
         </div>
       </div>
     );

diff --git a/client/src/components/LinkPicker/tests/LinkPicker-test.js b/client/src/components/LinkPicker/tests/LinkPicker-test.js
@@ -30,6 +30,14 @@ test('LinkPickerMenu render() should display cannot create message if cannot cre
   expect(container.querySelectorAll('.link-picker__cannot-create')).toHaveLength(1);
 });
 
+test('LinkPickerMenu render() should display cannot create message if types is empty', () => {
+  const { container } = render(<LinkFieldContext.Provider value={{ loading: false }}>
+    <LinkPicker {...makeProps({ types: {} })} />
+  </LinkFieldContext.Provider>);
+  expect(container.querySelectorAll('.link-picker__menu-toggle')).toHaveLength(0);
+  expect(container.querySelectorAll('.link-picker__cannot-create')).toHaveLength(1);
+});
+
 test('LinkPickerMenu render() should display link type icon if can create', () => {
   const { container } = render(<LinkFieldContext.Provider value={{ loading: false }}>
     <LinkPicker {...makeProps({ canCreate: true })} />