Selectively remove the "Open in new tab" option based on link type.

[maxime-rainville]

Story

As a CMS User I want the ability to get links to open in new tab where it makes sense

Acceptance criteria

• The "Open in new tab" option is the last form field by default.
• The "Open in new tab" option is removed from PhoneLink and EmailLink.

Designs

Link field - Overview

Note

All Link type currently have that option displayed, including some where it doesn't make sense like the Email Link type.

The placement of the option is also weird, because it the second option all the time, which give it an undue prominence.

PR

• ENH Hide the open in new window checkbox from phone and email links #187

[maxime-rainville]

Paul says:

• leave to user to decide by default.
• always display it at the end

Developers who are implementing custom link type will be responsible for removing the checkbox if they think it's not relevant.

[GuySartorelli]

PR merged