ENH Hide the open in new window checkbox from phone and email links #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/hide-checkbox
branch
from
d417f40 to
8cc5717
Compare
emteknetnz
commented
Jan 24, 2024
| ? _t(__CLASS__ . '.UPDATE_LINK', 'Update link') | ||
| : _t(__CLASS__ . '.CREATE_LINK', 'Create link'); | ||
| ? _t(__CLASS__ . '.UPDATE_LINK', 'Update link') | ||
| : _t(__CLASS__ . '.CREATE_LINK', 'Create link'); |
There was a problem hiding this comment.
This is unrelated refactoring
emteknetnz
force-pushed
the
pulls/4/hide-checkbox
branch
from
8cc5717 to
09d94a1
Compare
emteknetnz
commented
Jan 24, 2024
| 'file' => FileLink::class, | ||
| 'email' => EmailLink::class, | ||
| 'phone' => PhoneLink::class, | ||
| 'testphone' => TestPhoneLink::class, |
There was a problem hiding this comment.
This is unrelated refactoring to make it easier to run unit tests locally when you have a custom link type in your project
emteknetnz
commented
Jan 24, 2024
| FileLink::class, | ||
| EmailLink::class, | ||
| PhoneLink::class, | ||
| TestPhoneLink::class, |
There was a problem hiding this comment.
This is unrelated refactoring
emteknetnz
commented
Jan 24, 2024
| FileLink::class, | ||
| EmailLink::class, | ||
| PhoneLink::class, | ||
| TestPhoneLink::class, |
There was a problem hiding this comment.
This is unrelated refactoring
emteknetnz
commented
Jan 24, 2024
| $linkField = LinkField::create('LinkField'); | ||
| $linkField->setAllowedTypes($enabled); | ||
| $json = json_decode($linkField->getTypesProps(), true); | ||
| $json = $this->removeCustomLinkTypes($json); |
There was a problem hiding this comment.
This is unrelated refactoring to make it easier to run unit tests locally when you have a custom link type in your project
GuySartorelli
requested changes
Jan 24, 2024
emteknetnz
force-pushed
the
pulls/4/hide-checkbox
branch
from
09d94a1 to
7ef4494
Compare
emteknetnz
force-pushed
the
pulls/4/hide-checkbox
branch
from
7ef4494 to
0c01fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #23