Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to v3 #246

Closed
2 tasks
GuySartorelli opened this issue Mar 5, 2024 · 5 comments
Closed
2 tasks

Add deprecation warnings to v3 #246

GuySartorelli opened this issue Mar 5, 2024 · 5 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 5, 2024

This was originally part of #228

As a developer maintaining a project using LinkField v2/v3, I have a a clear path and clear guidance on how to migrate to v4.

Acceptance Criteria

  • Deprecations warnings are added to v3 for any public API which was removed in v4
  • The upgrade guide is updated to say to upgrade to (either 3.x-dev, 3.0.0, or 3.0.0-beta2 depending on the below) and resolve any deprecation warnings before migrating.

To be decided by @maxime-rainville:

  • Do we want to tag a 3.0.0-beta2 with the deprecations? Or just leave them on the 3 branch? Or tag stable?

PR

@maxime-rainville
Copy link

I think we need to tag something. My preference would be to tag 3.0.0 stable.

If that's not practical, 3.0.0-beta2 will work.

@GuySartorelli
Copy link
Member Author

PRs merged, reassigned to Steve for whatever's left

@emteknetnz
Copy link
Member

Assigning to @maxime-rainville to decide what to do regarding tagging

@maxime-rainville
Copy link

Unless someone is telling me that tagging 3.0.0 stable is not advisable, that is still my preferred option.

@emteknetnz
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants