Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Add deprecations #269

Merged
merged 1 commit into from
Apr 3, 2024
Merged

API Add deprecations #269

merged 1 commit into from
Apr 3, 2024

Conversation

emteknetnz
Copy link
Member

Issue #246

@emteknetnz emteknetnz mentioned this pull request Apr 3, 2024
Closed
2 tasks
GuySartorelli
GuySartorelli requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a few methods that do have replacements. I've suggested some wording but feel free to word it differently than my suggestions so long as it's consistent.

src/Models/EmailLink.php Outdated Show resolved Hide resolved
src/Models/ExternalLink.php Outdated Show resolved Hide resolved
src/Models/FileLink.php Outdated Show resolved Hide resolved
src/Models/FileLink.php Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
src/Models/PhoneLink.php Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
src/Type/Registry.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 210276f into silverstripe:3 Apr 3, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/deprecate branch April 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli