ENH Standardise API responses #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/standard-api
branch
5 times, most recently
from
08faf53 to
dd0e950
Compare
emteknetnz
force-pushed
the
pulls/4/standard-api
branch
from
dd0e950 to
ae594ba
Compare
GuySartorelli
requested changes
Jan 29, 2024
emteknetnz
force-pushed
the
pulls/4/standard-api
branch
from
ae594ba to
8fbe94b
Compare
GuySartorelli
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/developer-docs#422
201204 rather than 200 for empty body success responsesRequires silverstripe/silverstripe-admin#1658 to be merged first for CI to pass. Once that is merged mark this PR as ready for review and rerun tests.