Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Prevent nested asset-admin forms from submitting modal #190

Merged

Conversation

emteknetnz
Copy link
Member

Issue #156

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working around a wider issue, which is going to be handled properly in silverstripe/silverstripe-admin#1662

For now this is an okay solution for linkfield

client/src/components/LinkModal/LinkModal.js Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/filelink-submit branch from 9c8932a to da9ce9b Compare January 25, 2024 03:20
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@GuySartorelli GuySartorelli merged commit 7e077dc into silverstripe:4 Jan 25, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/filelink-submit branch January 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants