ENH Improve hover active and focus state styling #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/hover-styling
branch
2 times, most recently
from
dc7bc6c to
9be6397
Compare
emteknetnz
commented
Jan 26, 2024
sabina-talipova
suggested changes
Jan 29, 2024
emteknetnz
force-pushed
the
pulls/4/hover-styling
branch
2 times, most recently
from
02cedb0 to
e744de6
Compare
sabina-talipova
suggested changes
Jan 29, 2024
There was a problem hiding this comment.
@emteknetnz, there are still some issues with "span like button":
- if we use keyboard and press "Archive" then select "Cancel" in confirmation window the Link edit modal window will be open after browser confirmation window.
- Small style issue with External links.
emteknetnz
force-pushed
the
pulls/4/hover-styling
branch
2 times, most recently
from
f60611b to
d39d10b
Compare
sabina-talipova
suggested changes
Jan 29, 2024
| tabIndex="0" | ||
| className="link-picker__delete btn btn-link" | ||
| onKeyDown={(evt) => { | ||
| preventDefaultPropogation(evt); |
There was a problem hiding this comment.
@emteknetnz , could you, please, update this method. Since we have a small issue with moving further.
Probably we should replace it with stopPropagation and add evt.preventDefault() after onDelete(id)
Before (Cannot select Button below)
Screen.Recording.2024-01-29.at.4.14.17.PM.mov
After:
Screen.Recording.2024-01-29.at.4.16.10.PM.mov
emteknetnz
force-pushed
the
pulls/4/hover-styling
branch
from
d39d10b to
836d665
Compare
sabina-talipova
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #168
Has been demoed to and approved by design team