fix: update dynamic properties (#246) #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilr We've got a project here that is using module and that is being upgraded to php |
|
@jareddreyerss I think the tests failing is a pre-existing issue so not a blocker to using that. Aim to try and resolve those over the weekend but in the short term use my fork directly if you wish! |
wilr
force-pushed
the
fixes/246-dynamic-props
branch
from
ebaea28 to
eea755b
Compare
wilr
force-pushed
the
fixes/246-dynamic-props
branch
from
eea755b to
8ae2cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.