Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Replace Extension subclasses #212

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Extensions/MemberExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace SilverStripe\SessionManager\Extensions;

use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\ORM\HasManyList;
use SilverStripe\Security\Member;
use SilverStripe\SessionManager\FormFields\SessionManagerField;
Expand All @@ -14,9 +14,9 @@
*
* @method HasManyList<LoginSession> LoginSessions()
*
* @extends DataExtension<Member>
* @extends Extension<Member>
*/
class MemberExtension extends DataExtension
class MemberExtension extends Extension
{
/**
* URL to the user help abot managing session
Expand Down
4 changes: 2 additions & 2 deletions tests/php/Extensions/ForcePermission.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

namespace SilverStripe\SessionManager\Tests\Extensions;

use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\Dev\TestOnly;

/**
* This extension is meant to be applied to LoginSession so we can force permission to scenarios that won't happen
* natively with a default install of the session manager module.
*/
class ForcePermission extends DataExtension implements TestOnly
class ForcePermission extends Extension implements TestOnly
{
private static $canView = null;
private static $canDelete = null;
Expand Down
Loading