Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix unit test in kitchen sink #174

Merged

Conversation

GuySartorelli
Copy link
Member

This test was breaking in kitchen sink because AbstractQueuedJob adds specific data when subsites is installed:
https://github.com/symbiote/silverstripe-queuedjobs/blob/d8d4fece6e1e5feec0a3ca6c5c8a0b438a5892c1/src/Services/AbstractQueuedJob.php#L169-L174

Issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this target 6.0?

@GuySartorelli GuySartorelli force-pushed the pulls/6/fix-unit-test branch from a625085 to a881403 Compare October 3, 2023 20:37
@GuySartorelli GuySartorelli changed the base branch from 6 to 6.0 October 3, 2023 20:37
@GuySartorelli
Copy link
Member Author

Looks like it should, oops. I based it off 6 because that's where the original PR targetted - but it must have been before the stable release.
Now targetting 6.0

@emteknetnz emteknetnz merged commit e05c332 into silverstripe:6.0 Oct 3, 2023
9 checks passed
@emteknetnz emteknetnz deleted the pulls/6/fix-unit-test branch October 3, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants