Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate API which will be removed in CMS 6 #625

Merged
merged 1 commit into from
Jan 8, 2025
Merged

API Deprecate API which will be removed in CMS 6 #625

merged 1 commit into from
Jan 8, 2025

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Jan 8, 2025
Open
2 tasks
emteknetnz
emteknetnz requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsites is loosing support in CMS 6, don't bother with this, unless there's a really strong reason for this, this should just be closed

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Jan 8, 2025 •
edited
Loading

We said we'd make it CMS 6 compatible. The easiest way to do that is to just treat it as supported until the CMS 6 stable launch.
It can't really be CMS 6 compatible if it's calling method with the arguments in the wrong places.

@emteknetnz
Copy link
Member

emteknetnz commented Jan 8, 2025 •
edited
Loading

It'll still be CMS 6 compatible without any changes (unless I misunderstand this PR), though I do appreciate "just treat it the same" as a reason

Update: OK I see, the DataObject::get(..., $join) param will be removed in a later PR

@emteknetnz emteknetnz merged commit 49797c8 into silverstripe:3 Jan 8, 2025
13 checks passed
@emteknetnz emteknetnz deleted the pulls/3/deprecations branch January 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz