Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove unit test metadata #103

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 2, 2024

Issue silverstripe/.github#331

Not related to php84 though doing at same time, removes this notice

Metadata found in doc-comment for class SilverStripe\TextExtraction\Tests\TikaServerTextExtractorTest. Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

@emteknetnz emteknetnz marked this pull request as ready for review December 2, 2024 20:37
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bed76fe into silverstripe:5 Dec 2, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/php84 branch December 2, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants