Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LastEdited from summary_fields (Fixes #1170) #1173

Merged

Conversation

baukezwaan
Copy link
Contributor

Remove LastEdited from Submissions-overview (by using summary_fields), add Created and LastEdited to EditForm.
Fixes #1170

code/Model/Submission/SubmittedForm.php Outdated Show resolved Hide resolved
code/Model/Submission/SubmittedForm.php Outdated Show resolved Hide resolved
code/Model/EditableFormField.php Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli changed the base branch from 5 to 6 December 19, 2023 22:43
@GuySartorelli
Copy link
Member

I've retargetted this to the 6 branch so it can be included in the next minor release. Can you please rebase the PR against the 6 branch so CI can run again?

After that I'll be happy to merge.

@baukezwaan baukezwaan force-pushed the enh-remove-lastedited-from-summary branch from ec02ce4 to 53a6b05 Compare December 20, 2023 08:04
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, works well locally

@GuySartorelli GuySartorelli merged commit 5bcbad6 into silverstripe:6 Dec 20, 2023
12 checks passed
@baukezwaan baukezwaan deleted the enh-remove-lastedited-from-summary branch April 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LastEdited from summary fields
3 participants