-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LastEdited from summary_fields (Fixes #1170) #1173
Merged
GuySartorelli
merged 8 commits into
silverstripe:6
from
hamaka:enh-remove-lastedited-from-summary
Dec 20, 2023
Merged
Remove LastEdited from summary_fields (Fixes #1170) #1173
GuySartorelli
merged 8 commits into
silverstripe:6
from
hamaka:enh-remove-lastedited-from-summary
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Dec 18, 2023
I've retargetted this to the After that I'll be happy to merge. |
…, add Created and LastEdited to EditForm. Fixes silverstripe#1170
…rd is already created $defaults won't work
Co-authored-by: Guy Sartorelli <[email protected]>
baukezwaan
force-pushed
the
enh-remove-lastedited-from-summary
branch
from
December 20, 2023 08:04
ec02ce4
to
53a6b05
Compare
GuySartorelli
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, works well locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove LastEdited from Submissions-overview (by using summary_fields), add Created and LastEdited to EditForm.
Fixes #1170