Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Update behat tests to support toast messages #1250

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova force-pushed the pulls/5.15/test-toast-message branch from 6bbac24 to 29dddf2 Compare November 3, 2023 02:40
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why you're adding this? Was it failing there consistently? Or was it just a once-off failure? If you can re-run it and it passes, we don't tend to add additional wait statements, or we'd end up with an hour long behat run.

@sabina-talipova
Copy link
Contributor Author

The problem is that when we run the tests, they run on a small screen and the tab "Recipients" appears directly under the toast. Another option is to click on the close toast button, but this one is easier.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask you to use the "I dismiss all toasts" syntax but it looks like that's not available for CMS 4. Given that, and the fact that you're just adding this the once, and it seems like that's what has been done earlier in this same feature, I'll allow it.

@GuySartorelli GuySartorelli merged commit 62b4a59 into silverstripe:5.15 Nov 7, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.15/test-toast-message branch November 7, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants