-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent CMS requirements from leaking into preview email #1297
Conversation
I've added back the spot from the pull request template where a link to a issue needs to go. Can you please link to an issue? You'll need to create one if there isn't one already. This is important because it lets us track the issue in Zenhub, which the CMS Squad uses to keep track of the progress of issues. We don't track PRs, so this may not every be reviewed properly if there's no issue for us to track. |
Please also retarget this to the |
Rebased on 6.2 now! |
Ah another reason Zenhub should die! Far too much duplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's taken so long to review this. Mostly looks good, but should call Requirements::restore()
after rendering the template.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making that change
Description
When previewing an email template, the current behaviour is to include existing CMS styles which can be misleading.
Manual testing steps
Issues
Pull request checklist