Merge pull request #340 from creative-commoners/pulls/3/protect-hooks

API Set extension hook implementation visibility to protected
silverstripe · May 21, 2024 · eb0318d · eb0318d
2 parents 92f7bbf + 4e70426
commit eb0318d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/Extensions/ArchiveRestoreAction.php b/src/Extensions/ArchiveRestoreAction.php
@@ -28,7 +28,7 @@ class ArchiveRestoreAction extends DataExtension
      * @param Form $form
      * @return mixed
      */
-    public function updateItemEditForm(Form $form)
+    protected function updateItemEditForm(Form $form)
     {
         $record = $this->owner->getRecord();
 

diff --git a/src/Extensions/UsedOnTableExtension.php b/src/Extensions/UsedOnTableExtension.php
@@ -14,7 +14,7 @@ class UsedOnTableExtension extends Extension
     /**
      * @var array $excludedClasses
      */
-    public function updateUsageExcludedClasses(array &$excludedClasses)
+    protected function updateUsageExcludedClasses(array &$excludedClasses)
     {
         $excludedClasses[] = ChangeSetItem::class;
     }

diff --git a/tests/Extensions/ArchiveRestoreActionTest.php b/tests/Extensions/ArchiveRestoreActionTest.php
@@ -18,6 +18,8 @@
 use SilverStripe\Versioned\VersionedGridFieldItemRequest;
 use SilverStripe\VersionedAdmin\ArchiveAdmin;
 use SilverStripe\VersionedAdmin\Tests\Controllers\HistoryViewerControllerTest\ViewableVersionedObject;
+use ReflectionMethod;
+use SilverStripe\VersionedAdmin\Extensions\ArchiveRestoreAction;
 
 class ArchiveRestoreActionTest extends SapphireTest
 {
@@ -79,7 +81,12 @@ public function testUpdateItemEditForm()
             'test'
         );
 
-        $itemRequest->updateItemEditForm($form);
+        $ext = new ArchiveRestoreAction();
+        $method = new ReflectionMethod(ArchiveRestoreAction::class, 'updateItemEditForm');
+        $method->setAccessible(true);
+        $ext->setOwner($itemRequest);
+        $method->invokeArgs($ext, [$form]);
+
         $actions = $form->Actions();
         $this->assertInstanceOf(FormAction::class, $actions->fieldByName('action_doRestore'));
     }