Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT New test cases for doRestore button #334

Merged
merged 1 commit into from
Apr 12, 2024
Merged

MNT New test cases for doRestore button #334

merged 1 commit into from
Apr 12, 2024

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Apr 9, 2024 •
edited
Loading

@sabina-talipova sabina-talipova force-pushed the pulls/2.2/add-tests-dorestore branch from 476f951 to 6a179f0 Compare April 9, 2024 07:16
@sabina-talipova sabina-talipova mentioned this pull request Apr 9, 2024
Closed
4 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/2.2/add-tests-dorestore branch 5 times, most recently from 98149f2 to 7886ab4 Compare April 11, 2024 03:31
GuySartorelli
GuySartorelli requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change.

Please also add a behat test to the silverstripe/silverstripe-elemental repo for archiving and restoring elemental blocks, following the reproduction steps in the issue description.

tests/Behat/features/restore-to-draft.feature Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/2.2/add-tests-dorestore branch 4 times, most recently from c2d776f to bfdf8be Compare April 11, 2024 22:51
@sabina-talipova sabina-talipova force-pushed the pulls/2.2/add-tests-dorestore branch from bfdf8be to dee7670 Compare April 11, 2024 22:57
GuySartorelli
GuySartorelli approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 085e933 into silverstripe:2.2 Apr 12, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.2/add-tests-dorestore branch April 12, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli