We're calling a method (having) that doesn't exist on DataList

[sabina-talipova]

Description

Method having() doesn't exist in DataList class, but we're trying to call it If Versioned::Versions() receives $having parameter.

We need to either add that method to DataList or apply the $having argument via alterDataQuery()

See

silverstripe-versioned/src/Versioned.php

Lines 2008 to 2026 in 5359490

	public function Versions($filter = "", $sort = "", $limit = "", $join = "", $having = "")
	{
	/** @var DataObject $owner */
	$owner = $this->owner;
	// When an object is not yet in the Database, we can't get its versions
	if (!$owner->isInDB()) {
	return ArrayList::create();
	}
	// Make sure the table names are not postfixed (e.g. _Live)
	$oldMode = static::get_reading_mode();
	static::set_stage(static::DRAFT);
	$list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $join, $limit);
	if ($having) {
	// @todo - This method doesn't exist on DataList
	$list->having($having);
	}

Acceptance criteria

• The $having argument in Versioned::Versions() can be called without throwing an exception and can be meaningfully use.

Note

We are assuming that this can be done relatively easily. But if it turns out to be very difficult, bring it back for re-refinement.

PR

• API Deprecate Versions() having parameter #425
• DOC Deprecated $having parameter developer-docs#396

[GuySartorelli]

Marking as impact/high.
This would be a critical in other circumstances, but the fact that this hasn't caused actual problems until now mitigates its impact somewhat.

[GuySartorelli]

PR merged. Reassigning to Steve to add a note to the PR about the deprecated parameter.

[emteknetnz]

Reassigning to Steve to add a note to the PR about the deprecated parameter.

Not sure what I'm supposed to do here?

[GuySartorelli]

Changelog, sorry.

[emteknetnz]

PR added

[GuySartorelli]

PRs merged