API Deprecate Versions() having parameter #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/2.1/deprecate-having
branch
from
151353a to
44d071d
Compare
|
This wasn't one of the options discussed in refinement. Why not implement having on datalist, or use |
|
Having a better look at this now seems like this param on Versions() that shouldn't have been there in the first place, so it doesn't make sense IMO to do work to support it |
GuySartorelli
requested changes
Nov 5, 2023
There was a problem hiding this comment.
Need to target 2. We don't deprecate API in patch releases.
Not super happy with this approach but it's an improvement on what we had, since it's not throwing an error any time someone tries to use the parameter now - so I'll be okay with it when it's targetting the 2 branch.
emteknetnz
force-pushed
the
pulls/2.1/deprecate-having
branch
from
44d071d to
5e245df
Compare
|
@GuySartorelli done |
emteknetnz
force-pushed
the
pulls/2.1/deprecate-having
branch
from
5e245df to
4d38781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #417
Currently this parameter is used and if called could cause a hard error since the having() method doesn't exist on DataList
I'm not even sure why this paramater ever existed since I'm not sure how it could even be used in this context since you're calling DataList::get() and then passing through the $filter, $sort, $limit and $join paramaters ... though there doesn't seem like there's anyway to even use having since it's not creating a select SQL statement with an aggregate function like
count()in itSeems best to just prevent it from even attempting to call the non-existant DataList::having() and deprecate it