-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Remove TODO comments #418
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,8 +188,6 @@ protected function getObjectDisplay($object = null) | |
} | ||
|
||
// Use image tag | ||
// TODO Use CMSThumbnail instead to limit max size, blocked by DataDifferencerTest and GC | ||
// not playing nice with mocked images | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #414 |
||
if ($object instanceof Image) { | ||
return $object->getTag(); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,7 +201,6 @@ public function findOwners($recursive = true, $list = null) | |
} | ||
|
||
// Build reverse lookup for ownership | ||
// @todo - Cache this more intelligently | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like a small warning. |
||
$rules = $this->lookupReverseOwners(); | ||
|
||
// Hand off to recursive method | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2021,7 +2021,6 @@ public function Versions($filter = "", $sort = "", $limit = "", $join = "", $hav | |
|
||
$list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $join, $limit); | ||
if ($having) { | ||
// @todo - This method doesn't exist on DataList | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #417 |
||
$list->having($having); | ||
} | ||
|
||
|
@@ -2656,8 +2655,6 @@ public static function get_latest_version($class, $id) | |
/** | ||
* Returns whether the current record is the latest one. | ||
* | ||
* @todo Performance - could do this directly via SQL. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like an additional way for better performance. |
||
* | ||
* @see get_latest_version() | ||
* @see latestPublished | ||
* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,8 +70,7 @@ public function testArrayValues() | |
$obj1v2 = Versioned::get_version(DataDifferencerTest\TestObject::class, $obj1->ID, $afterVersion); | ||
$differ = new DataDifferencer($obj1v1, $obj1v2); | ||
$obj1Diff = $differ->diffedData(); | ||
// TODO Using getter would split up field again, bug only caused by simulating | ||
// an array-based value in the first place. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open ticket: #413 |
||
|
||
$this->assertContainsIgnoreWhitespace('<del>a,b</del><ins>a</ins>', $obj1Diff->getField('Choices')); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open ticket: #415