Stop completion message from displaying when no action is taken

silverstripe · Sep 19, 2019 · fc0a43e · fc0a43e
1 parent 32ba6fd
commit fc0a43e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Console/VendorExposeCommand.php b/src/Console/VendorExposeCommand.php
@@ -50,10 +50,11 @@ public function execute(InputInterface $input, OutputInterface $output)
         // Expose all modules
         $method = $input->getArgument('method');
         $task = new VendorExposeTask($this->getProjectPath(), new Filesystem(), $basePublicPath);
-        $task->process($io, $modules, $method);
 
-        // Success
-        $io->write("All modules updated!");
+        if ($task->process($io, $modules, $method)) {
+            // Success
+            $io->write("All modules updated!");
+        }
     }
 
     /**

diff --git a/src/VendorExposeTask.php b/src/VendorExposeTask.php
@@ -63,7 +63,7 @@ public function process(IOInterface $io, array $libraries, $methodKey = null)
     {
         // No-op
         if (empty($libraries)) {
-            return;
+            return false;
         }
 
         // Setup root folder
@@ -76,7 +76,7 @@ public function process(IOInterface $io, array $libraries, $methodKey = null)
         $method = $this->getMethod($methodKey);
 
         if ($methodKey === VendorPlugin::METHOD_NONE) {
-            return;
+            return false;
         }
 
         // Update all modules
@@ -100,6 +100,8 @@ public function process(IOInterface $io, array $libraries, $methodKey = null)
 
         // On success, write `.method` token to persist for subsequent updates
         $this->saveMethodKey($methodKey);
+
+        return true;
     }