Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui.plot.PlotWidget: Fixed support of PySide6 #4136

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Jun 14, 2024

Checklist:


This PR adds an accepted exception type to those that can happen during PlotWidget.hideEvent with PySide6.
This aims at fixing the CI on Windows with PySide6:

__________________ TestPixelIntensitiesHisto.testShowAndHide __________________
self = <silx.gui.plot.test.testPixelIntensityHistoAction.TestPixelIntensitiesHisto testMethod=testShowAndHide>
    def tearDown(self):
        del self.plotImage
>       super(TestPixelIntensitiesHisto, self).tearDown()
venv_test\Lib\site-packages\silx\gui\plot\test\testPixelIntensityHistoAction.py:50: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <silx.gui.plot.test.testPixelIntensityHistoAction.TestPixelIntensitiesHisto testMethod=testShowAndHide>
    def tearDown(self):
        self.qapp.processEvents()
    
        if len(self.__class__._exceptions) > 0:
            messages = "\n".join(self.__class__._exceptions)
>           raise AssertionError("Exception occured in Qt thread:\n" + messages)
E           AssertionError: Exception occured in Qt thread:
E           Traceback (most recent call last):
E           AttributeError: Slot 'FitAction::' not found.
venv_test\Lib\site-packages\silx\gui\utils\testutils.py:193: AssertionError
------------------------------ Captured log call ------------------------------
ERROR    silx.gui.plot.PlotWidget:PlotWidget.py:835 Exception occured: The SignalInstance object was already deleted

@t20100 t20100 added this to the Next release milestone Jun 14, 2024
@vallsv vallsv merged commit a96820b into silx-kit:main Aug 29, 2024
7 of 8 checks passed
@t20100 t20100 deleted the fix-ci-pyside branch September 3, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants