Allow auto adjusting letterSpacing #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove use of deprecated `textScaleFactor` in place of the preferred `TextScaler` (https://docs.flutter.dev/release/breaking-changes/deprecate-textscalefactor) * Upgrade required Dart SDK versions, make necessary project updates on Android demo app
cxavier20
force-pushed
the
auto_letter_spacing
branch
from
5681b32 to
a0c87d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #73.
The letter spacing resizing is done when it reaches the
MinFontSizeand the text still does not fit. There is no need to resize the letter spacing earlier since resizing the text size already reduces the space between each character.I did not add a
maxLetterSpacingsince I did not find it relevant. You can set the max letter spacing in the starting text style.