Skip to content

some cleaning

some cleaning #175

Triggered via pull request May 28, 2024 01:07
Status Failure
Total duration 2m 53s
Billable time 5m
Artifacts

dotnet.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 30 warnings
Build and test on ubuntu-latest
Process completed with exit code 1.
Build and test on windows-latest
Process completed with exit code 1.
Build and test on macos-latest: src/UTF8.cs#L294
In member SimdUnicode.UTF8.calculateErrorPathadjust(int, int, byte*, int, int, int), remove the underscores from parameter name start_point (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
Build and test on macos-latest: src/Ascii.cs#L28
In externally visible method 'bool Ascii.IsAscii(string s)', validate parameter 's' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on macos-latest: benchmark/Benchmark.cs#L49
Member 'PriorityInCategory' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on macos-latest: benchmark/Benchmark.cs#L50
Member 'IsNumeric' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on macos-latest: benchmark/Benchmark.cs#L133
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on macos-latest: benchmark/Benchmark.cs#L134
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on macos-latest: benchmark/Benchmark.cs#L134
Avoid unnecessary zero-length array allocations. Use Array.Empty<byte>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825)
Build and test on macos-latest: benchmark/Benchmark.cs#L149
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build and test on macos-latest: benchmark/Benchmark.cs#L162
In externally visible method 'void RealDataBenchmark.RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)', validate parameter 'validationFunction' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on macos-latest: benchmark/Benchmark.cs#L162
In externally visible method 'void RealDataBenchmark.RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)', validate parameter 'data' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on ubuntu-latest: src/UTF8.cs#L294
In member SimdUnicode.UTF8.calculateErrorPathadjust(int, int, byte*, int, int, int), remove the underscores from parameter name start_point (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
Build and test on ubuntu-latest: src/Ascii.cs#L28
In externally visible method 'bool Ascii.IsAscii(string s)', validate parameter 's' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L49
Member 'PriorityInCategory' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L50
Member 'IsNumeric' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L133
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L134
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L134
Avoid unnecessary zero-length array allocations. Use Array.Empty<byte>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L149
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L162
In externally visible method 'void RealDataBenchmark.RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)', validate parameter 'validationFunction' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on ubuntu-latest: benchmark/Benchmark.cs#L162
In externally visible method 'void RealDataBenchmark.RunDotnetRuntimeUtf8ValidationBenchmark(byte[] data, DotnetRuntimeUtf8ValidationFunction validationFunction)', validate parameter 'data' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on windows-latest: src/UTF8.cs#L294
In member SimdUnicode.UTF8.calculateErrorPathadjust(int, int, byte*, int, int, int), remove the underscores from parameter name start_point (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
Build and test on windows-latest: src/Ascii.cs#L28
In externally visible method 'bool Ascii.IsAscii(string s)', validate parameter 's' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on windows-latest: benchmark/Benchmark.cs#L49
Member 'PriorityInCategory' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on windows-latest: benchmark/Benchmark.cs#L50
Member 'IsNumeric' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
Build and test on windows-latest: benchmark/Benchmark.cs#L133
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on windows-latest: benchmark/Benchmark.cs#L134
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
Build and test on windows-latest: benchmark/Benchmark.cs#L134
Avoid unnecessary zero-length array allocations. Use Array.Empty<byte>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825)
Build and test on windows-latest: benchmark/Benchmark.cs#L149
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build and test on windows-latest: benchmark/Benchmark.cs#L146
In externally visible method 'void RealDataBenchmark.RunUtf8ValidationBenchmark(byte[] data, Utf8ValidationFunction validationFunction)', validate parameter 'validationFunction' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
Build and test on windows-latest: benchmark/Benchmark.cs#L146
In externally visible method 'void RealDataBenchmark.RunUtf8ValidationBenchmark(byte[] data, Utf8ValidationFunction validationFunction)', validate parameter 'data' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)